Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade metadata to puppet 8, require Boolean type #72

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Upgrade metadata to puppet 8, require Boolean type #72

merged 7 commits into from
Oct 10, 2023

Conversation

Enucatl
Copy link
Contributor

@Enucatl Enucatl commented Oct 10, 2023

@trefzer
Copy link
Contributor

trefzer commented Oct 10, 2023

Hi Enucatl
Thanks a lot for this PR. I added some comments.....

trefzer
trefzer requested changes Oct 10, 2023
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
lib/puppet/type/libvirt_domain.rb Outdated Show resolved Hide resolved
lib/puppet/type/libvirt_network.rb Show resolved Hide resolved
lib/puppet/type/libvirt_nwfilter.rb Show resolved Hide resolved
@Enucatl
Copy link
Contributor Author

Enucatl commented Oct 10, 2023

@trefzer I implemented the requested changes and added a note to the README about installing rexml, with a link to the docs.

@trefzer trefzer merged commit fafdcbb into cirrax:master Oct 10, 2023
2 checks passed
@trefzer
Copy link
Contributor

trefzer commented Oct 10, 2023

Hi Mateo
looks great, thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trefzer trefzer trefzer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade to Puppet 8 uninitialized constant Puppet::Parameter::Boolean
2 participants
@Enucatl @trefzer