Skip to content

Commit

Permalink
add rexml gem to .sync.yml and instructions on README
Browse files Browse the repository at this point in the history
  • Loading branch information
Enucatl committed Oct 10, 2023
1 parent 835b860 commit 82043e7
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,6 @@ Gemfile:
':development':
- gem: 'puppet-blacksmith'
- gem: 'github_changelog_generator'

- gem: 'rexml'
version: '~> 3.2'
condition: "Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3')"
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ group :development do
gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
gem "puppet-blacksmith", require: false
gem "github_changelog_generator", require: false
gem "rexml", '~> 3.2', require: false if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3')
end
group :system_tests do
gem "puppet_litmus", '~> 1.0', require: false, platforms: [:ruby, :x64_mingw]
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@
5. [Contributing](#contributing)

## Upgrade warnings:

Upgrading to puppet 8 comes with Ruby 3, which doesn't have the `rexml` gem bundled.
It should be [installed on the puppetserver](https://www.puppet.com/docs/puppet/7/server/gems.html#installing-and-removing-gems).
```
sudo puppetserver gem install rexml
```

Upgrade to version 5.x.x introduced types/providers for network, nwfilter and domains
replacing the execs used before version 5.0.0. To compare the XML's generated with puppet and
the actual running XML's generated with virsh they are sorted which leads to display lots of
Expand Down

0 comments on commit 82043e7

Please sign in to comment.