Allow CA & EAM to intercom (with channels), but not across Coalition #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit ID is not deterministic based on Unit ID's. If testing finds that this ignores Coalition, Add it here.
This means spectators are locked to a single intercom channel, but its not a big minus, because Combined Arms Slots gain that capability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #720 but this should be more coherent and less scattered. It centralizes all of the case switching in the Sync Handler.
The following cases were tested between two clients with these changes on an existing server.
Cases to test:
1: ✅ Blue EAM <-> Spectator, Exp: No Comms
2: ✅ Blue EAM <-> Blue Controller, Exp: Working Comms
3: ✅ Blue EAM, Intercom Ch1 <-> Blue Controller, Intercom Ch2, Exp: No Comms
4: ✅ Blue EAM, Intercom Ch2 <-> Blue Controller, Intercom Ch1, Exp: No Comms
5: ✅ Blue EAM <-> Red Controller, Exp: No Comms
5.5 ✅Blue EAM <-> Red EAM, Exp: No Comms.