MOD: out of range circ-median-ci #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! Is it possible to add a test with some artificial data for this special case (to |
|
@miki998 Thank you very much again, and Happy New Year! I'll take a look after the New Year break. |
huangziwei
reviewed
Jan 9, 2025
| @@ -0,0 +1,19 @@ | |||
| ,alpha | |||
There was a problem hiding this comment.
If the data is as simple as this, we don't need to add it as a dataset, but simply put, alpha = np.arange(18) within the test_circ_median_ci(). Moreover, I tried this but it doesn't break the original code. Maybe I didn't make it clear enough before: can you provide a case of artificial data which breaks the original code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the implementation of pycircstat2, continuing on the former pycircstat.
I quickly got started and stumbled upon a small problem when instantiating a Circle (I unfortunately can't really share the bug), I suggested a very tiny patch for that feel free to check it out and see if it makes sense.