Compiling fixes from other forks #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformatted to remove MLint warnings - added commas for multiple output arguments, - removed redundant semicolons Files end with one blank line and non-nested functions have "ends"
Dim now defaults to the first non-singular dimension, rather than just the first. This matches most matlab functions a bit more closely. For example, circ_mean([0 2*pi]) and circ_mean([0 2*pi]') now both return pi, rather than [0 2*pi] and pi, depending.
This way, warnings can be selectively turned on/off.
Actual code unchanged.
With the use of the logarithm of the gamma function, Hodges' exact formula for the p-value may be used reliably for sample sizes up to at least 10^7, if not greater. For n < 50, where the exact formula was previously implemented using nchoosek, the implementation using gammaln to compute the binomial coefficients agrees with that using nchoosek. Co-Authored-By: Jacob Zavatone-Veth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in fixes from other forks.
Addresses:
#3 (indirectly, technically the transpose should be removed instead)
#6
#7