chore: Use fork of dependency review action #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscaltreto
force-pushed
the
forked-dependency-review-action
branch
from
a0d2a11
to
a9c996a
Compare
jscaltreto
force-pushed
the
forked-dependency-review-action
branch
from
a9c996a
to
2c403ba
Compare
igaskin
approved these changes
Nov 6, 2024
jscaltreto
pushed a commit
that referenced
this pull request
Nov 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.2](v1.3.1...v1.3.2) (2024-11-06) ### Miscellaneous Chores * Use fork of dependency review action ([#22](#22)) ([6779eda](6779eda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream depenendency-review-action uses the change's
package_url(as returned from the dependency graph API) to match against the exclusions passed viaallow-dependencies-licenses. However, some changes do not includepackage_url, but they can still result in the action failing a license check as the check itself doesn't rely onpackage_url. Currently there's no mechanism in place to exclude a dependency from the license check if the package_url is empty.I created a fork of the action and added a fallback mechanism that parses
source_repository_urlto attempt to match based on the repository name using thegithubPURL type. Soallow-dependencies-licensescould include, for example,pkg:github/owner/repoand that would match a change withsource_repository_url: "https://github.com/owner/repo".This doesn't cover all cases; if
source_repository_urlis empty or doesn't point to a github-hosted repository then it will still fail to match, but this should cover a good number of cases.