Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark discipline-munit as a test dependency #353

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Conversation

biochimia
Copy link
Contributor

@biochimia biochimia commented Aug 22, 2022

After adding circe-jackson to a project I noticed test dependencies being pulled into the classpath, and tracked them down to the use of discipline-munit here. As far as I can tell this is only used in tests here, too, so it should be okay to scope the dependency.

Copy link

@yuntaoL yuntaoL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found this issue either. By checking the code, discipline-munit is only used in unit test.

@zarthross
Copy link
Member

Fixes #411

@zarthross zarthross modified the milestones: v0.14.0, v0.14.1 Nov 16, 2023
@zarthross zarthross merged commit b5506e6 into circe:master Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants