Skip to content

Qodana

Qodana #7

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / Qodana for JVM completed Aug 10, 2023 in 0s

239 new problems found by Qodana for JVM

Qodana for JVM

239 new problems were found

Inspection name Severity Problems
@Transactional self-invocation method calls 🔶 Warning 5
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 4
@NotNull/@Nullable problems 🔶 Warning 3
Redundant 'if' statement 🔶 Warning 3
Deprecated API usage 🔶 Warning 2
Field can be local 🔶 Warning 2
Field may be 'final' 🔶 Warning 2
Mismatch between Javadoc and code 🔶 Warning 2
Non-final field in 'enum' 🔶 Warning 2
Unchecked warning 🔶 Warning 2
Constant values 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Statement with empty body 🔶 Warning 1
Javadoc declaration problems 🔶 Warning 1
Redundant escape in regex replacement string 🔶 Warning 1
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 1
Call to 'set.removeAll(list)' may work slowly 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Unnecessary semicolon 🔶 Warning 1
Non recommended 'field' injections ◽️ Notice 201
Duplicated code fragment ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 113 in src/main/java/de/cinovo/cloudconductor/server/model/EAuthToken.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Condition `o.revokeDate == null` is always `true` when reached

Check warning on line 52 in src/main/java/de/cinovo/cloudconductor/server/repo/provider/FileProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Dereference of `dir.listFiles()` may produce `NullPointerException`

Check warning on line 62 in src/main/java/de/cinovo/cloudconductor/server/util/AWSClientFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Deprecated API usage

'createClient(java.lang.Class, com.amazonaws.auth.AWSCredentialsProvider, com.amazonaws.ClientConfiguration)' is deprecated

Check warning on line 45 in src/main/java/de/cinovo/cloudconductor/server/util/AWSClientFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Deprecated API usage

'createClient(java.lang.Class, com.amazonaws.auth.AWSCredentialsProvider, com.amazonaws.ClientConfiguration)' is deprecated

Check notice on line 65 in src/main/java/de/cinovo/cloudconductor/server/handler/PackageStateHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Duplicated code fragment

Duplicated code

Check notice on line 65 in src/main/webapp/src/app/configvalues/cv.variables.comp.ts

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Duplicated code fragment

Duplicated code

Check warning on line 82 in src/main/java/de/cinovo/cloudconductor/server/repo/provider/AWSS3Provider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Statement with empty body

`if` statement has empty body

Check warning on line 26 in src/main/java/de/cinovo/cloudconductor/server/handler/GlobalConfigMigrator.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 52 in src/main/java/de/cinovo/cloudconductor/server/util/JMXResourceProvider.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Field can be local

Field can be converted to a local variable

Check warning on line 20 in src/main/java/de/cinovo/cloudconductor/server/model/enums/TagColor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Field may be 'final'

Field `css` may be 'final'

Check warning on line 31 in src/main/java/de/cinovo/cloudconductor/server/handler/ConfigValueHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Field may be 'final'

Field `configValueDAO` may be 'final'

Check warning on line 18 in src/main/java/de/cinovo/cloudconductor/server/repo/importer/IPackageImport.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Javadoc declaration problems

`@param repo` tag description is missing

Check warning on line 230 in src/main/java/de/cinovo/cloudconductor/server/model/EFile.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Mismatch between Javadoc and code

Method is specified to return list but the return type is set

Check warning on line 48 in src/main/java/de/cinovo/cloudconductor/server/dao/IFileDAO.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Mismatch between Javadoc and code

Method is specified to return list but the return type is number

Check warning on line 20 in src/main/java/de/cinovo/cloudconductor/server/model/enums/TagColor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Non-final field in 'enum'

Non-final field `css` in enum 'TagColor'

Check warning on line 89 in src/main/java/de/cinovo/cloudconductor/server/repo/indexer/RPMIndexer.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Non-final field in 'enum'

Non-final field `depStates` in enum 'RPMPrimaryState'

Check warning on line 137 in src/main/java/de/cinovo/cloudconductor/server/tasks/ServerTaskHelper.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems

Not annotated parameter overrides @NonNullApi parameter

Check warning on line 54 in src/main/java/de/cinovo/cloudconductor/server/tasks/AbstractTrigger.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems

Not annotated parameter overrides @NonNullApi parameter

Check warning on line 106 in src/main/java/de/cinovo/cloudconductor/server/model/EAuthToken.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

@NotNull/@Nullable problems

Not annotated parameter overrides @NotNull parameter

Check warning on line 64 in src/main/java/de/cinovo/cloudconductor/server/rest/utils/JavaArgsWriter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Redundant escape in regex replacement string

Redundant escape of '"'

Check warning on line 144 in src/main/java/de/cinovo/cloudconductor/server/util/GenericModelApiConverter.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

'size() == 0' can be replaced with 'isEmpty()'

`name.length() != 0` can be replaced with '!name.isEmpty()'

Check warning on line 110 in src/main/java/de/cinovo/cloudconductor/server/handler/PackageStateChangeHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Call to 'set.removeAll(list)' may work slowly

Call to 'set.removeAll(list)' may work slowly

Check notice on line 43 in src/main/java/de/cinovo/cloudconductor/server/handler/RepoHandler.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Non recommended 'field' injections

Field injection is not recommended

Check notice on line 51 in src/main/java/de/cinovo/cloudconductor/server/rest/ui/HostImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Non recommended 'field' injections

Field injection is not recommended

Check notice on line 68 in src/main/java/de/cinovo/cloudconductor/server/rest/ui/TemplateImpl.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Non recommended 'field' injections

Field injection is not recommended