Internal refactor #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A public interface of blend layer used internal key structure which made it impossible to be used outside of cinode repo.
This change hides the internal data of BlobKey and BlobIV types to ensure those internals can not be relied on in outside code.
The goal is to create proper API on top of protobuf instead ensuring that we preserve additional internal consistency.
* Introduce abstract node structure, all recursive functions are now realized through those nodes and implementations of node interface method implementations. * Introduce generic traversal logic - a common code paths are now used for graph traversal and only the final step that deals with the target node is customized for specific logic. That way bug fixing and testing can be done on a common path improving overall code quality.
static datastore compiler. Now can use URL notation which allows direct upload to HTTP and HTTPS datastores.
* Add option to generate index files * Add option to append to existing datastore * Small internal refactor
This is much more natural in Go where lack of value is usually denoted through nil as opposed to default value.
It is a larger topic and will be handled separately.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 88.73% 93.55% +4.81%
==========================================
Files 32 49 +17
Lines 1927 3055 +1128
==========================================
+ Hits 1710 2858 +1148
+ Misses 181 141 -40
- Partials 36 56 +20 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.