Handle index.html redirection in HTTP layer

cinode · Sep 5, 2023 · 72b22ea · 72b22ea
1 parent 90fc2f5
commit 72b22ea
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/pkg/cmd/cinode_web_proxy/root.go b/pkg/cmd/cinode_web_proxy/root.go
@@ -101,11 +101,11 @@ func setupCinodeProxy(
 		),
 		RootEntrypoint:   entrypoint,
 		MaxLinkRedirects: 10,
-		IndexFile:        "index.html",
 	}
 
 	return &structure.HTTPHandler{
-		FS: &fs,
+		FS:        &fs,
+		IndexFile: "index.html",
 	}
 }
 

diff --git a/pkg/cmd/static_datastore/static_datastore_test.go b/pkg/cmd/static_datastore/static_datastore_test.go
@@ -137,11 +137,11 @@ func (s *CompileAndReadTestSuite) validateDataset(
 		BE:               blenc.FromDatastore(ds),
 		RootEntrypoint:   ep,
 		MaxLinkRedirects: 10,
-		IndexFile:        "index.html",
 	}
 
 	testServer := httptest.NewServer(&structure.HTTPHandler{
-		FS: &fs,
+		FS:        &fs,
+		IndexFile: "index.html",
 	})
 	defer testServer.Close()
 

diff --git a/pkg/datastore/webinterface_test.go b/pkg/datastore/webinterface_test.go
@@ -32,7 +32,7 @@ import (
 )
 
 func testServer(t *testing.T) string {
-	log := slog.New(slog.NewTextHandler(io.Discard))
+	log := slog.New(slog.NewTextHandler(io.Discard, nil))
 
 	// Test web interface and web connector
 	server := httptest.NewServer(WebInterface(

diff --git a/pkg/structure/cinodefs.go b/pkg/structure/cinodefs.go
@@ -33,7 +33,6 @@ type CinodeFS struct {
 	BE               blenc.BE
 	RootEntrypoint   *protobuf.Entrypoint
 	MaxLinkRedirects int
-	IndexFile        string
 	CurrentTimeF     func() time.Time
 }
 
@@ -67,10 +66,6 @@ func (d *CinodeFS) findEntrypointInDir(
 		return nil, ErrNotADirectory
 	}
 
-	if remainingPath == "" {
-		remainingPath = d.IndexFile
-	}
-
 	rc, err := d.OpenContent(ctx, ep)
 	if err != nil {
 		return nil, err

diff --git a/pkg/structure/http.go b/pkg/structure/http.go
@@ -25,7 +25,8 @@ import (
 )
 
 type HTTPHandler struct {
-	FS *CinodeFS
+	FS        *CinodeFS
+	IndexFile string
 }
 
 func (h *HTTPHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
@@ -34,7 +35,11 @@ func (h *HTTPHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	path := strings.TrimPrefix(r.URL.Path, "/")
+	path := r.URL.Path
+	if strings.HasSuffix(path, "/") {
+		path += h.IndexFile
+	}
+	path = strings.TrimPrefix(path, "/")
 
 	fileEP, err := h.FS.FindEntrypoint(r.Context(), path)
 	switch {