Use random port in tests

cinode · Nov 19, 2023 · 4fa3eb5 · 4fa3eb5
1 parent 245b332
commit 4fa3eb5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/pkg/cmd/cinode_web_proxy/root.go b/pkg/cmd/cinode_web_proxy/root.go
@@ -164,8 +164,8 @@ func getConfig() (*config, error) {
 		cfg.port = 8080
 	} else {
 		portNum, err := strconv.Atoi(port)
-		if err == nil && (portNum < 1 || portNum > 65535) {
-			err = fmt.Errorf("not in range 1..65535")
+		if err == nil && (portNum < 0 || portNum > 65535) {
+			err = fmt.Errorf("not in range 0..65535")
 		}
 		if err != nil {
 			return nil, fmt.Errorf("invalid listen port %s: %w", port, err)

diff --git a/pkg/cmd/cinode_web_proxy/root_test.go b/pkg/cmd/cinode_web_proxy/root_test.go
@@ -289,6 +289,7 @@ func TestExecute(t *testing.T) {
 		ep := testblobs.DynamicLink.Entrypoint()
 
 		t.Setenv("CINODE_ENTRYPOINT", ep.String())
+		t.Setenv("CINODE_LISTEN_PORT", "0")
 		ctx, cancel := context.WithCancel(context.Background())
 		go func() {
 			time.Sleep(10 * time.Millisecond)

diff --git a/pkg/cmd/public_node/root.go b/pkg/cmd/public_node/root.go
@@ -174,8 +174,8 @@ func getConfig() (*config, error) {
 		cfg.port = 8080
 	} else {
 		portNum, err := strconv.Atoi(port)
-		if err == nil && (portNum < 1 || portNum > 65535) {
-			err = fmt.Errorf("not in range 1..65535")
+		if err == nil && (portNum < 0 || portNum > 65535) {
+			err = fmt.Errorf("not in range 0..65535")
 		}
 		if err != nil {
 			return nil, fmt.Errorf("invalid listen port %s: %w", port, err)

diff --git a/pkg/cmd/public_node/root_test.go b/pkg/cmd/public_node/root_test.go
@@ -189,6 +189,8 @@ func TestExecuteWithConfig(t *testing.T) {
 
 func TestExecute(t *testing.T) {
 	t.Run("valid configuration", func(t *testing.T) {
+		t.Setenv("CINODE_LISTEN_PORT", "0")
+
 		ctx, cancel := context.WithCancel(context.Background())
 		go func() {
 			time.Sleep(10 * time.Millisecond)