tetra: fix --policy-names to apply all event types
#3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
reviewed
Oct 25, 2024
pkg/filters/filters.go
Outdated
|
|
||
| switch ev := (response.Event).(type) { | ||
| case *tetragon.GetEventsResponse_ProcessKprobe: | ||
| return ev.ProcessKprobe.PolicyName |
There was a problem hiding this comment.
Any reason for not using GetPolicyName() here? It's a bit safer if the pointer is nil which shouldn't happen normally but better to avoid crashing
There was a problem hiding this comment.
I think using GetPolicyName() is better, thanks!
In cilium#1867, the `--policy-names` flag was added to filter events based on the tracing policy. However, the filter was only appled to `kprobe` events. This patch extends the filter to support all events types: `kprobe`, `tracepoint`, `uprobe` and `lsm`. Signed-off-by: Justin Chen <[email protected]>
justin0u0
force-pushed
the
fix/tetra-filter-policy-names
branch
from
e84d039
to
547ccdd
Compare
mtardy
added
the
release-note/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1867, the
--policy-namesflag was added to filter events based on the tracing policy. However, the filter was only appled tokprobeevents.This patch extends the filter to support all events types:
kprobe,tracepoint,uprobeandlsm.