Add an optional cluster_name field to GetEventsResponse #3025
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michi-covalent
force-pushed
the
pr/michi/cluster-name
branch
from
90e393d
to
d0ebbb0
Compare
Add an optional cluster_name field to GetEventsResponse. To enable the field, set tetragon.clusterName Helm value. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/cluster-name
branch
from
d0ebbb0
to
f5781b6
Compare
michi-covalent
changed the title
michi-covalent
added
the
release-note/minor
There was a problem hiding this comment.
i wonder if some default name would be better than empty string. "default-cluster-name" or better. With empty string we also will trigger warning that cluster name was not provided so we cant differentiate pods of same id running in different clusters, like development and production etc.
There was a problem hiding this comment.
what warning will it trigger? having default cluster name won't help differentiating events from different clusters right? 💭
edit: also i mildly prefer not changing the behavior for existing installations.
There was a problem hiding this comment.
i mean we in Hypershield will look for not specified cluster name and trigger warning, not on Tetragon side.
Add an optional cluster_name field to GetEventsResponse. To enable the field, set tetragon.clusterName Helm value.