pkg/sensors: fix memory use of unloaded sensors #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
the
release-note/bug
|
Regarding the metrics talked here #2984 (comment), I think it still makes sense to report 0 for a disabled policy. |
mtardy
commented
Oct 21, 2024
Sensors that are disabled are not loaded and should not use memory, thus we clear the LoadedMapsInfo on unloading programs. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/disable-kernel-memory
branch
from
b350f2c
to
8e2c979
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This adds a high level tests making sure that the kernel memory bytes stat is working and that disabling/enabling a policy should do what expected with regard to kernel memory usage. Signed-off-by: Mahe Tardy <[email protected]>
lambdanis
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3013
Sensors that are disabled are not loaded and should not use memory, thus we clear the LoadedMapsInfo on unloading programs.