Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tetragon_msg_op_total metric #2856

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Sep 1, 2024

  1. Remove tetragon_msg_op_total metric

    tetragon_msg_op_total was counting events per opcode in the ring buffer queue.
    It wasn't particularly useful, as there are other metrics exposing similar
    numbers:
    * tetragon_bpf_missed_events_total counting missed events per opcode in BPF
    * tetragon_observer_ringbuf_queue_events_received_total counting total events
      received in the ring buffer queue
    * tetragon_events_total counting events per event type in grpc
    
    If needed, in the future we can add opcode label to metrics counting events in
    the observer:
    * tetragon_observer_ringbuf_events_received_total
    * tetragon_observer_ringbuf_queue_events_received_total
    * tetragon_observer_ringbuf_queue_events_lost_total
    
    We could also add a metric counting all events (not only missed) per opcode in
    BPF. However, it's unclear if they could be useful - ringbuffer and events
    queue shouldn't discriminate different types of events, so having total counts
    of successful and missed events at each stage should be enough to troubleshoot
    capacity issues. There is still a per event type counter at the last stage, for
    monitoring overall data volume.
    
    Signed-off-by: Anna Kapuscinska <[email protected]>
    lambdanis committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    7791130 View commit details
    Browse the repository at this point in the history