Extend metrics library #2572
Closed
Extend metrics library #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
36ff590
to
386866f
Compare
lambdanis
added
release-note/misc
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
386866f
to
3f6b4de
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lambdanis
force-pushed
the
pr/lambdanis/library
branch
2 times, most recently
from
876f3ee
to
cc929de
Compare
lambdanis
force-pushed
the
pr/lambdanis/library
branch
5 times, most recently
from
4cb47a1
to
022d16d
Compare
This is a general rewrite of pkg/metrics library, but it a fully backwards compatible way. Goals and key components are described in doc.go, so I won't repeat them here. Fixes: cilium#2376 Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/library
branch
from
022d16d
to
e1f335d
Compare
|
I'm closing this PR in favour of #2606 - it's the same PR but opened from a branch inside the repo instead of the fork, so that I can easily stack follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general rewrite of
pkg/metricslibrary, but it a fully backwardscompatible way. Goals and key components are described in
doc.go, so I wouldsuggest starting the review there :)
For usage examples see #2604 (defining health metrics group, migrating some custom metrics & collectors to the new interface).
Fixes: #2376