-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/michi/prateek copy #1281
Pr/michi/prateek copy #1281
Conversation
eff7c3d
to
9528821
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e7572f2
to
0f62317
Compare
4e66141
to
0966bf1
Compare
// createTetragonPod creates a tetragonPod resource. | ||
func createTetragonPod(ctx context.Context, pod *corev1.Pod, r *TetragonPodReconciler, l logr.Logger) (ctrl.Result, error) { | ||
// create the tetragon pod since the pod exists | ||
if pod.Status.Phase == corev1.PodRunning { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of waiting for the pod to start, we want to create TetragonPod
as soon as we have all the necessary info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that to reduce the logs being generated, because the controller is triggered for every state change too. I should use log.Debug
instead of log.Info
as you suggested. Should I instead for the pod.Status.Phase == corev1.PodPending
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just re-confirming. The controller will wait for all the necessary information it needs, once done, it will create the respective tetragonPods right ?
}, | ||
Status: ciliumiov1alpha1.TetragonPodStatus{ | ||
PodIP: newIP.IP, | ||
PodIPs: make([]ciliumiov1alpha1.PodIP, 0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy PodIPs
field too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
0966bf1
to
c9fda92
Compare
c9fda92
to
c128c91
Compare
c128c91
to
2efe846
Compare
@prateek041 please rebase against main branch to pick up #1351 🙏 🚀 |
This commit: - Initializes a Project with Name podinfo and repo github.com/cilium/tetragon - Provide builderplate code for creating the operator Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]> Signed-off-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
081f388
to
20e3874
Compare
Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
e2caa7c
to
3075c6e
Compare
Signed-off-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
Signed-off-by: Prateek Singh <[email protected]>
let's close this one. we are using #1410 instead |
to test it locally: