-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cilium/cilium to v1.13.4 #1211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
force-pushed
the
pr/apapag/update_cilium_1134
branch
from
July 11, 2023 08:31
6c87dfb
to
0b3754a
Compare
#1100 has issues so we need to do than manually. Will fix some Dependabot alerts: https://github.com/cilium/tetragon/security/dependabot/31 https://github.com/cilium/tetragon/security/dependabot/30 https://github.com/cilium/tetragon/security/dependabot/34 https://github.com/cilium/tetragon/security/dependabot/35 Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/update_cilium_1134
branch
5 times, most recently
from
July 11, 2023 09:13
c04b0eb
to
e72f805
Compare
Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/update_cilium_1134
branch
from
July 11, 2023 09:16
e72f805
to
d63c481
Compare
tpapagian
commented
Jul 11, 2023
@@ -51,6 +51,7 @@ jobs: | |||
GOPATH: ${{ env.GITHUB_WORKSPACE }}/go | |||
SUDO: sudo -E | |||
run: | | |||
go clean -cache -modcache -testcache -fuzzcache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting an error in gotests without that:
[...]
gcc -Wall exit-code.c -o exit-code -lpthread
gcc -Wall -fPIC uprobe-lib.c -o libuprobe.so -shared
gcc -Wall uprobe-test.c -o uprobe-test-1 /home/runner/work/tetragon/tetragon/go/src/github.com/cilium/tetragon/contrib/tester-progs/libuprobe.so
cp uprobe-test-1 uprobe-test-2
go build -o lseek-pipe ./go/lseek-pipe
open /home/runner/.cache/go-build/ca/ca1e2fb1ac5d864e241cc2379993cf70727712c40e99cc34bfe4fa90ae232d57-d: permission denied
make[1]: *** [Makefile:56: lseek-pipe] Error 1
make[1]: Leaving directory '/home/runner/work/tetragon/tetragon/go/src/github.com/cilium/tetragon/contrib/tester-progs'
make: *** [Makefile:355: tester-progs] Error 2
Error: Process completed with exit code 2.
[...]
kkourt
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1100 has issues so we need to do than manually.
Will fix some Dependabot alerts:
https://github.com/cilium/tetragon/security/dependabot/31 https://github.com/cilium/tetragon/security/dependabot/30 https://github.com/cilium/tetragon/security/dependabot/34 https://github.com/cilium/tetragon/security/dependabot/35
Also update Go from 1.18 to 1.19 in actions which seems to be a requirement for this update.