New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bigInt function with comprehensive tests #949

Closed

Daniel-Grounin wants to merge 1 commit into cieslarmichal:main from Daniel-Grounin:add-bigInt-function

Daniel-Grounin commented Oct 5, 2024

This PR introduces the implementation of the bigInt function in the Number module.

Added support for generating random BigInt numbers within a specific range.
Updated unit tests to cover various scenarios, including valid ranges, negative ranges, and edge cases like same min and max values.
All tests were run and passed successfully.

Please review the changes and let me know if there are any adjustments needed. Thank you!

Fixed line-ending issues (CRLF/LF) that were causing changes across all lines of the files, making it hard to review. Now, only the necessary changes are visible in the diff.


          fix: add updated bigInt function with tests

6cf0cfe

cieslarmichal requested changes

View reviewed changes

include/faker-cxx/number.h

@@ @@ -4,6 +4,7 @@ @@
               #include <optional>
               #include <random>
               #include <stdexcept>
+              #include <optional>

Owner

cieslarmichal Oct 5, 2024

Optional is already included above

cieslarmichal linked an issue

that may be closed by this pull request

add bigInt function to Number module #940

Open

Daniel-Grounin closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet