Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bigInt function to Number module #948

Closed

Conversation

Daniel-Grounin
Copy link

Summary

Added a bigInt function to the Number module that generates random BigInt values between a specified range, with optional parameters for min and max. This function follows the format of existing methods and supports edge cases like negative values and exact range matches.

Changes

  • Implemented bigInt in number.cpp and added declarations in number.h.
  • Wrote unit tests in number_test.cpp to verify functionality for valid, negative, and exact ranges.
  • Verified that all tests pass successfully.

Tests

All relevant tests for the bigInt function pass.

Let me know if further changes are required! 😊

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason in your changes all lines are deleted and then inserted, maybe line ending or something? Please take a look at that because I cant review it properly, not sure what changed

@cieslarmichal cieslarmichal linked an issue Oct 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add bigInt function to Number module
2 participants