241

[SidMalladi]

#241 - Add new functionalites to Phone module @cieslarmichal

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adef940) 98.78% compared to head (8c50239) 98.82%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   98.78%   98.82%   +0.04%     
==========================================
  Files          47       47              
  Lines        2954     3072     +118     
==========================================
+ Hits         2918     3036     +118     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SidMalladi]

Hi @cieslarmichal , I've made the suggested changes, can you please review and merge?

[cieslarmichal]

extract data to data/ directory and use it in both cpp and test.cpp files

[SidMalladi]

hi @cieslarmichal just made the changes

[cieslarmichal]

compilation error - it should be data/, not faker-cxx/data/

[cieslarmichal]

Also, you defined this data in separate file - good, but you are not using it anywhere, should be used instead defining those vectors again in implementation an test cases