Add person first and last names data from Spain #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
|
Oops, it seems the MSVC build has failed and I have no idea what the error message means. Can I get some help ? Also, for code coverage, it seems that random files were uncovered by my code. I don't know what this is due to. |
|
Please add /bigobj flag to msvc flags in CMakeLists.txt in project root here: if (MSVC) |
cieslarmichal
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As always, I took data from Faker-JS.
I felt there weren't enough first names, so I added a few new ones I found on https://www.familyeducation.com/baby-names/first-name/origin/spanish (Yep, that's a random website I found when I searched for new first names 😂)
Don't hesitate to tell me if you see a problem in the code I added or if I missed to implement something :^)
Closes #100