Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lch function to Color module #215

Merged

Conversation

saharmyhre
Copy link
Contributor

Added the LCH to color module (you can ignore the name of the branch, it says ich because I misread in the beginning but the code uses lch and the commit message as well).

@cieslarmichal cieslarmichal linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/modules/color/ColorTest.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@cieslarmichal cieslarmichal merged commit f152795 into cieslarmichal:main Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lch function to Color module
3 participants