Feature/weather #214
Merged
Feature/weather #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I changed anything to mess that up lol... I'll double check |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
cieslarmichal
approved these changes
Nov 2, 2023
|
Nice one, good job 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this should be better now. I changed the conversions so that both the metric and imperial were equivalent and not two random numbers. I was not sure how you wanted to format structs so I hope the way I did it was okay. Please get back to me on any changes needed.
On a semi-related note my tests all passed however I did see some tests fail (every couple dozen tries in Person/Full Name). If I can find it I'll open an issue for that.