Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

160-feature/animal module #176

Merged

Conversation

Globostofo
Copy link
Contributor

@Globostofo Globostofo commented Oct 4, 2023

Took data from faker-js

Added animals:

  • bears
  • birds
  • cats
  • cetaceans
  • cows
  • crocodilia
  • dogs
  • fishes
  • horses
  • insects
  • lions
  • rabbits
  • rodents
  • snakes
  • types (generates a random string from the previous animal)

Closes #160

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/modules/animal/AnimalTest.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, left one comment :)

@Globostofo
Copy link
Contributor Author

Oops, I forgot documentation.

It's good now, I added it :)

@cieslarmichal cieslarmichal merged commit ab482b7 into cieslarmichal:main Oct 5, 2023
3 checks passed
@Globostofo Globostofo deleted the 160-feature/animal-module branch October 5, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add animal module
3 participants