add tv shows to movie module (#208)

cieslarmichal · Oct 16, 2023 · d85b230 · d85b230
1 parent 786d834
commit d85b230
Show file tree

Hide file tree

Showing 6 changed files with 419 additions and 262 deletions.
diff --git a/include/faker-cxx/Movie.h b/include/faker-cxx/Movie.h
@@ -29,6 +29,17 @@ class Movie
      */
     static std::string movieTitle();
 
+    /**
+     * @brief Returns a random tv show.
+     *
+     * @returns Tv show.
+     *
+     * @code
+     * Movie::tvShow() // "The Sopranos"
+     * @endcode
+     */
+    static std::string tvShow();
+
     /**
      * @brief Returns a random movie director name.
      *

diff --git a/src/modules/movie/Movie.cpp b/src/modules/movie/Movie.cpp
@@ -4,7 +4,8 @@
 #include "data/Actresses.h"
 #include "data/Directors.h"
 #include "data/Genres.h"
-#include "data/MovieTitles.h"
+#include "data/Movies.h"
+#include "data/TvShows.h"
 #include "faker-cxx/Helper.h"
 
 namespace faker
@@ -16,7 +17,12 @@ std::string Movie::genre()
 
 std::string Movie::movieTitle()
 {
-    return Helper::arrayElement<std::string>(movieTitles);
+    return Helper::arrayElement<std::string>(movies);
+}
+
+std::string Movie::tvShow()
+{
+    return Helper::arrayElement<std::string>(tvShows);
 }
 
 std::string Movie::director()
@@ -33,4 +39,5 @@ std::string Movie::actress()
 {
     return Helper::arrayElement<std::string>(actresses);
 }
+
 }
diff --git a/src/modules/movie/MovieTest.cpp b/src/modules/movie/MovieTest.cpp
@@ -8,7 +8,8 @@
 #include "data/Actresses.h"
 #include "data/Directors.h"
 #include "data/Genres.h"
-#include "data/MovieTitles.h"
+#include "data/Movies.h"
+#include "data/TvShows.h"
 
 using namespace ::testing;
 using namespace faker;
@@ -30,10 +31,18 @@ TEST_F(MovieTest, shouldGenerateMovieTitle)
 {
     const auto generatedMovieTitle = Movie::movieTitle();
 
-    ASSERT_TRUE(std::ranges::any_of(movieTitles, [generatedMovieTitle](const std::string& movieTitle)
+    ASSERT_TRUE(std::ranges::any_of(movies, [generatedMovieTitle](const std::string& movieTitle)
                                     { return generatedMovieTitle == movieTitle; }));
 }
 
+TEST_F(MovieTest, shouldGenerateTvShow)
+{
+    const auto generatedTvShow = Movie::tvShow();
+
+    ASSERT_TRUE(std::ranges::any_of(tvShows, [generatedTvShow](const std::string& tvShow)
+                                    { return generatedTvShow == tvShow; }));
+}
+
 TEST_F(MovieTest, shouldGenerateDirector)
 {
     const auto generatedDirector = Movie::director();

diff --git a/src/modules/movie/data/MovieTitles.h b/src/modules/movie/data/MovieTitles.h