feat::Add multilanguage sexes (Issue #251) 101b

cieslarmichal · Nov 25, 2023 · 9e9d902 · 9e9d902
1 parent bf04c0e
commit 9e9d902
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/include/faker-cxx/Person.h b/include/faker-cxx/Person.h
@@ -105,7 +105,7 @@ class Person
      * Person::sex() // "Male"
      * @endcode
      */
-    static std::string sex();
+    static std::string sex(Language language = Language::English);
 
     /**
      * @brief Returns a random gender.

diff --git a/include/faker-cxx/types/Sex.h b/include/faker-cxx/types/Sex.h
@@ -66,12 +66,6 @@ inline std::string toString(Sex sex, Language language = Language::English)
     return translateSex(sex, language);
 }
 
-// inline std::string toString(Sex sex,const std::string& language = "English")
-//{
-//     std::map<Sex, std::string> sexToStringMapping{{Sex::Male, "Male"}, {Sex::Female, "Female"}};
-//
-//     return sexToStringMapping.at(sex);
-// }
 
 inline std::ostream& operator<<(std::ostream& os, Sex sex)
 {

diff --git a/src/modules/person/Person.cpp b/src/modules/person/Person.cpp
@@ -288,9 +288,13 @@ std::string Person::suffix()
     return Helper::arrayElement<std::string>(allSuffixes);
 }
 
-std::string Person::sex()
+std::string Person::sex(Language language)
 {
-    return Helper::arrayElement<std::string>(sexes);
+    std::string chosenSex = Helper::arrayElement<std::string>(sexes);
+
+    Sex sexEnum = chosenSex == "Male" ? Sex::Male : Sex::Female;
+
+    return translateSex(sexEnum, language);
 }
 
 std::string Person::gender()