Clean up

cieslarmichal · Jul 27, 2023 · 2abf0cc · 2abf0cc
1 parent 63b964d
commit 2abf0cc
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 16 deletions.
diff --git a/include/faker-cxx/Number.h b/include/faker-cxx/Number.h
@@ -385,11 +385,11 @@ class Number
      * Number::convertToHex(255) // "ff"
      *
      */
-    static std::string convertToHex(int number);
 
 private:
     static std::random_device randomDevice;
     static std::mt19937 pseudoRandomGenerator;
+    static std::string convertToHex(int number);
 
 };
 }
diff --git a/src/modules/internet/InternetTest.cpp b/src/modules/internet/InternetTest.cpp
@@ -622,7 +622,6 @@ TEST_F(InternetTest, shouldGenerateIpv4KeepingTheMaskedPart)
 TEST_F(InternetTest, MacDefaultSeparator)
 {
     std::string mac = Internet::mac();
-    std::cout << mac << std::endl;
     ASSERT_EQ(mac.size(), 17);
 
     for (size_t i = 0; i < mac.size(); i += 3) {

diff --git a/src/modules/number/NumberTest.cpp b/src/modules/number/NumberTest.cpp
@@ -81,34 +81,20 @@ TEST_F(NumberTest, HexMethodTest)
 {
 
     std::string result = Number::hex();
-    std::cout << result << std::endl;
     ASSERT_EQ(result.size(), 1);
     ASSERT_TRUE(std::isxdigit(result[0]));
 
     result = Number::hex(100, 255);
-    std::cout << result << std::endl;
     ASSERT_EQ(result.size(), 2);
     ASSERT_TRUE(std::isxdigit(result[0]));
     ASSERT_TRUE(std::isxdigit(result[1]));
 
     result = Number::hex(10, 15);
-    std::cout << result << std::endl;
     ASSERT_EQ(result.size(), 1);
     ASSERT_TRUE(std::isxdigit(result[0]));
 
     result = Number::hex(30, 40);
-    std::cout << result << std::endl;
     ASSERT_EQ(result.size(), 2);
     ASSERT_TRUE(std::isxdigit(result[0]));
     ASSERT_TRUE(std::isxdigit(result[1]));
 }
-
-TEST_F(NumberTest, ConvertToHexMethodTest)
-{
-    ASSERT_EQ(Number::convertToHex(0), "0");
-    ASSERT_EQ(Number::convertToHex(9), "9");
-    ASSERT_EQ(Number::convertToHex(10), "a");
-    ASSERT_EQ(Number::convertToHex(15), "f");
-    ASSERT_EQ(Number::convertToHex(16), "10");
-    ASSERT_EQ(Number::convertToHex(255), "ff");
-}