improve password generation (#229)

cieslarmichal · Nov 10, 2023 · 05f306d · 05f306d
1 parent 9ee5465
commit 05f306d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/modules/internet/Internet.cpp b/src/modules/internet/Internet.cpp
@@ -92,7 +92,8 @@ std::string Internet::exampleEmail(std::optional<std::string> firstName, std::op
 
 std::string Internet::password(int length)
 {
-    const std::string passwordCharacters = "0123456789!@#$%^&*abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
+    const std::string passwordCharacters =
+        "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789~`!@#$%^&*()_-+={[}]|:;\"'<,>.?/";
 
     std::string password;
 

diff --git a/src/modules/internet/InternetTest.cpp b/src/modules/internet/InternetTest.cpp
@@ -24,6 +24,8 @@ using namespace faker;
 
 namespace
 {
+const std::string passwordCharacters =
+    "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789~`!@#$%^&*()_-+={[}]|:;\"'<,>.?/";
 const std::vector<std::string> webProtocols{"http", "https"};
 const std::vector<std::string> httpMethodNames{"GET", "POST", "DELETE", "PATCH", "PUT"};
 const std::vector<unsigned> httpStatusInformationalCodes{100, 101, 102, 103};
@@ -359,25 +361,21 @@ TEST_F(InternetTest, shouldGenerateExampleEmailWithFullName)
 
 TEST_F(InternetTest, shouldGeneratePassword)
 {
-    const std::string passwordCharacters = "0123456789!@#$%^&*abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
-
     const auto password = Internet::password();
 
     ASSERT_EQ(password.size(), 15);
-    ASSERT_TRUE(std::ranges::all_of(password, [passwordCharacters](char passwordCharacter)
+    ASSERT_TRUE(std::ranges::all_of(password, [&](char passwordCharacter)
                                     { return passwordCharacters.find(passwordCharacter) != std::string::npos; }));
 }
 
 TEST_F(InternetTest, shouldGeneratePasswordWithSpecifiedLength)
 {
     const auto passwordLength = 25;
 
-    const std::string passwordCharacters = "0123456789!@#$%^&*abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
-
     const auto password = Internet::password(passwordLength);
 
     ASSERT_EQ(password.size(), passwordLength);
-    ASSERT_TRUE(std::ranges::all_of(password, [passwordCharacters](char passwordCharacter)
+    ASSERT_TRUE(std::ranges::all_of(password, [&](char passwordCharacter)
                                     { return passwordCharacters.find(passwordCharacter) != std::string::npos; }));
 }