Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep only deployment workflow #24

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Keep only deployment workflow #24

merged 5 commits into from
Nov 3, 2024

Conversation

xames3
Copy link
Collaborator

@xames3 xames3 commented Nov 3, 2024

  • as the title says, this pull request adds changes which are pertaining to keeping on the relevant deployment workflows i.e deployment.yml file and deprecates the linting.yml file.
  • at no point, any existing features have been compromised.

@xames3
docs(open science 101): upstream guide to remote
34a3a43 
Signed-off-by: Akshay Mestry <[email protected]>
@xames3
build(Makefile): update Makefile to build smartly
9804cc7 
Impact Analysis:
    - This change introduces smartly build sphinx documentation with
      minimal to no-code commands. The updated Makefile takes care of the
      documentation building. However, if the documentation building
      process needs extra arguments, they should fallback to the verbose
      `sphinx-build` method.
    - This change adds native support for sphinx-linting before every
      build, ensuring the code quality is maintained.

Signed-off-by: Akshay Mestry <[email protected]>
@xames3
docs(101): upstream page about accounts setup
c725bbf 
Description:
    - This change adds support for accounts setup page. Although not
      fully finished, the page marks as a good starting point for further
      documentation and exploration.

Signed-off-by: Akshay Mestry <[email protected]>
@xames3
ci: remove linting in favor of only deployment
2327713 
BREAKING CHANGE:
    - This change deprecates the use of linting workflow in favor of
      only deployment. This change doesn't compromises any functionality
      but merely simplifies the workflow.

Signed-off-by: Akshay Mestry <[email protected]>
@xames3 xames3 added enhancement enhancements to existing functionality or the addition of new features or content wontfix this pull request or issue will not be worked on breaking change pull requests that alter the project in a way that is not backward-compatible approved pull requests that have passed review and are cleared for merging ci/cd modifications to CI/CD pipelines or processes high priority pull requests that should be reviewed and merged as a priority due to their importance miscellaneous miscellaneous changes and some of the general inner workings labels Nov 3, 2024
@xames3 xames3 self-assigned this Nov 3, 2024
@xames3 xames3 merged commit 50f9ed9 into canary Nov 3, 2024
3 checks passed
@xames3 xames3 deleted the features/xames3-ci-deployment-pipeline branch November 3, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xames3 xames3

Labels
approved pull requests that have passed review and are cleared for merging breaking change pull requests that alter the project in a way that is not backward-compatible ci/cd modifications to CI/CD pipelines or processes enhancement enhancements to existing functionality or the addition of new features or content high priority pull requests that should be reviewed and merged as a priority due to their importance miscellaneous miscellaneous changes and some of the general inner workings wontfix this pull request or issue will not be worked on
Projects
TOPS SCHOOL NLU Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xames3