Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix canary patch #19

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Hotfix canary patch #19

merged 11 commits into from
Oct 31, 2024

Conversation

xames3
Copy link
Collaborator

@xames3 xames3 commented Oct 31, 2024

No description provided.

Impact Analysis:
    - For some reason, the JupyterLite patch failed on the CI checkout.
      This seems quite strange as on the all the local and SI testing,
      it did seem to work. But nonetheless, removed it for now to test
      the overall deployment process.

Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis:
    - In all the internal testings, everything seemed to be quite right
      yet the JupyterLite seemed to cause some issues which are
      currently not yet identified to be resolved for a complete proof.
    - Hence, removing the inputs where JupyterLite was considered as
      important. This is by no means trying to put an end to the use of
      JupyterLite, we very much will investigate this further down the
      road but as of now, it seems not relevant.

Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
@xames3 xames3 added duplicate this issue or pull request already exists invalid not a bug but, this pull request or issue doesn't seem right wontfix this pull request or issue will not be worked on approved pull requests that have passed review and are cleared for merging ci/cd modifications to CI/CD pipelines or processes work in progress pull requests that are not yet ready for review or merging labels Oct 31, 2024
@xames3 xames3 self-assigned this Oct 31, 2024
@xames3 xames3 merged commit 81cc87c into canary Oct 31, 2024
1 check passed
@xames3 xames3 deleted the features/xames3-canary-patch branch November 3, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved pull requests that have passed review and are cleared for merging ci/cd modifications to CI/CD pipelines or processes duplicate this issue or pull request already exists invalid not a bug but, this pull request or issue doesn't seem right wontfix this pull request or issue will not be worked on work in progress pull requests that are not yet ready for review or merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant