Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST requests should have query params in the body #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ammmir
Copy link

@ammmir ammmir commented Apr 4, 2011

Some sites (like Instagram) will ignore the query string parameters for POST requests, as they're expecting them in the request body.

@langalex
Copy link

+1

@amcjen
Copy link

amcjen commented May 20, 2011

I made a similar patch for Instagram as well, which solved this same issue. +1 for a pull request for this fix.

@hsztul
Copy link

hsztul commented Jul 18, 2011

+1

@langalex
Copy link

any reason this is not being integrated? i just wasted an hour implementing it myself because i forgot about this fork.

@kytrinyx
Copy link

kytrinyx commented Sep 3, 2011

+1

@ciaranj
Copy link
Owner

ciaranj commented Apr 24, 2012

Can anyone confirm if this is still an issue ? I was about to merge this in, when I noted it conflicts with some work around always POSTing to retrieve the access token.. it may no longer be an issue ?

@langalex
Copy link

looks like this line solves it already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants