Calculating the signature of foo=1&bar=false removes the value "false" #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar&lorem=false, was calculated wrong since it compared false to "" (which gives true) so the value false was omitted. This fix just makes sure that the value is compared with === "" to check whether its an empty string. Since JS gives var a = false; a == "" // true, we have to use ===
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JS will equal "" == false, when the signature is calculated in oauth.js, a property with a value of false will get the parameters for the signature without the actual "false", since it was checked agains "". So to fix this we just need to test all properties with === instead of ==.
Otherwise, the signature check will fail if the server end calculates the signature correctly.