missing response.setEncoding('utf8') #119
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought oauth2.js missed one line
response.setEncoding('utf8')
, the oauh.js has this line.But missing the line, the
chunk
is a buffer, andresult+= chunk
will cause encoding problem. Because one char in utf8 (one char in may bytes) maybe separated into two buffers. andresult+=chunk
implies chunk convert to string first, so one good char becomes two broken char.This is the same problem as issues #118, and I think pull request #80 is a good idea, but it should be applied to oauth2.js as well.