Improve octree, bvh, renderer and output mode dropdowns. #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
force-pushed
the
better-dropdowns
branch
from
6817bb2
to
ac8c34f
Compare
leMaik
commented
Sep 9, 2023
| public Tooltip getTooltip(Registerable item) { | ||
| String description = item.getDescription(); | ||
| if (description != null && !description.isEmpty()) { | ||
| return new Tooltip(item.getDescription()); |
There was a problem hiding this comment.
Suggested change
| return new Tooltip(item.getDescription()); | |
| return new Tooltip(description); |
leMaik
commented
Sep 9, 2023
| @@ -836,8 +836,8 @@ public OctreeImplementation getImplementation() { | |||
| return implementation; | |||
| } | |||
|
|
|||
| public static void addImplementationFactory(String name, ImplementationFactory factory) { | |||
| factories.put(name, factory); | |||
| public static void addImplementationFactory(ImplementationFactory factory) { | |||
There was a problem hiding this comment.
This breaking change is bad and we should find a way to work around this (maybe a backward-compatible ImplementationFactory and a new RegisterableImplementationFactory).
ThatRedox
reviewed
Sep 9, 2023
| @@ -39,12 +39,12 @@ public interface RenderManager { | |||
| /** | |||
| * Get all available {@code Renderer}s. | |||
| */ | |||
| Collection<? extends Registerable> getRenderers(); | |||
| Collection<Renderer> getRenderers(); | |||
There was a problem hiding this comment.
This would make it impossible for plugins to implement RenderManager and have their own type of swappable renderer that is incompatible with Chunky's renderers. (Which kinda defeats the point of changing the RenderManager implementation).
There was a problem hiding this comment.
Oh… Okay, so a renderer doesn't have to be a Renderer?
There was a problem hiding this comment.
Yeah, Renderer is just the interface to work with Chunky's DefaultRenderManager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.