-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding attributes to catch stray debug prints before merging #154
base: main
Are you sure you want to change the base?
Adding attributes to catch stray debug prints before merging #154
Conversation
… println gets caught in ci
@chshersh You were right with this. This needs to be added at the top of #![deny(clippy::print_stdout)]
#[deny(clippy::print_stdout)]
mod completion;
#[deny(clippy::print_stdout)]
mod config;
#[deny(clippy::print_stdout)]
mod infra;
#[deny(clippy::print_stdout)]
mod install;
#[deny(clippy::print_stdout)]
mod model;
#[deny(clippy::print_stdout)]
mod sync; |
Resolves #148Resolves #156
This pr does not actually resolve any issue but it will prevent stray debug println from being commited to themain
branch in the future.This pr adds attributes to all the modules imported in
src/lib.rs
. These attributes prevent stray debugprintln!
s from making it into themain
branch.For future reference, you can annotate your function or method with the following attribute so clippy passes ci:
Additional tasks
- [ ] Documentation for changes provided/changed- [ ] Tests added- [ ] Updated CHANGELOG.md