Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shellcheck #153

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

add shellcheck #153

wants to merge 7 commits into from

Conversation

hdhoang
Copy link
Contributor

@hdhoang hdhoang commented Oct 22, 2022

Resolves #146

For unsupported tar compressions, i made a string-based io::Error. I tried adding an AssetError variant for clarity, but constructing it in archive.rs proved much difficult. But it shouldn't be reachable because of Archive::from anyhow.

I added an early $name-$tag string because threading ToolAsset fields through the function added many &str parameters, which then get combined at the leaf exe_paths.

Additional tasks

  • Documentation for changes provided/changed
  • Tests added
  • Updated CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh Awaiting requested review from chshersh chshersh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groundwork for shellcheck
1 participant
@hdhoang