-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#107] Remove dynamically-linked 'tool-sync' asset #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good! 👍🏻
But the CI is failing. Not sure why tbh 🤔
@jim4067 What error do you get if you run tool-sync
locally by trying to download tool-sync
itself?
It works with mine but I get a different error, maybe there is a typo in your file name?
|
A question
|
You can generate a default by running |
@MitchellBerend Maybe it can be a future feature request to create the file with default configuration. As I am on Linux, I think this will require implementation of #71 first |
@chshersh I tried installing it but the connection timed out (multiple times). I then tried installing |
What distro are you running @jim4067? |
@MitchellBerend I'm running Pop OS NAME="Pop!_OS" |
Huh, thats weird Im running ubuntu 22.04 lts. Can you follow that link in your browser or does that also time out? Distributor ID: Ubuntu |
I think I was having connection problems. Similar issue of multiple name matches |
Co-authored-by: Dmitrii Kovanikov <[email protected]>
The changes in this PR look great and CI finally passes! 🎉 Happy to merge the PR 🚢 As for generating the default configuration, this was discussed before. I don't think we need to do this but we still can improve UX. I created a separate issue to improve the error message when there's no configuration found: |
Resolves #107
Additional tasks