Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown formatting fixes bonanza #156

Merged
merged 8 commits into from
Apr 21, 2024
Merged

Markdown formatting fixes bonanza #156

merged 8 commits into from
Apr 21, 2024

Conversation

sadlerm4
Copy link
Contributor

Addresses #152

In addition:

  • Remove separator line when it directly precedes h2
  • Change remaining legacy bold text headings to h4 (apologies for not catching all of them last time round)
  • Use the same bullet symbol for lists throughout
  • Move instructions on how to install ectool from faq to "Using Ectool" page
  • Change some tip container headings to "note" for general aesthetics
  • Where it does not refer to terminal input/output, change monospace formatted text to normal text formatting in quotation marks
  • Add nice Unicode symbols to ChromeOS VT-x keyboard shortcut references
  • Simplify overly verbose instructions
  • Spelling

@sadlerm4 sadlerm4 marked this pull request as ready for review April 15, 2024 04:40
@ninelore ninelore linked an issue Apr 15, 2024 that may be closed by this pull request
SEO: Headers #152
Closed
ninelore
ninelore reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint

src/docs/firmware/recovery-mode.md Outdated Show resolved Hide resolved
src/docs/firmware/index.md Outdated Show resolved Hide resolved
ninelore
ninelore requested changes Apr 15, 2024
View reviewed changes
src/docs/reverting/making-recovery-usb.md Show resolved Hide resolved
src/docs/firmware/index.md Outdated Show resolved Hide resolved
@ninelore
Copy link
Member

ninelore commented Apr 16, 2024 •
edited
Loading

in 85be021 you changed alot of intents to 3sp. Was this intentional?

ninelore
ninelore previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No SEO-relevant issues left.

Markdownlint still shows alot of trivial issues in regards to #87. Its up to you if you want toi fix em aswell.

Other than that: LGTM

@sadlerm4
Copy link
Contributor Author

No SEO-relevant issues left.

Markdownlint still shows alot of trivial issues in regards to #87. Its up to you if you want toi fix em aswell.

Other than that: LGTM

I'll do that in a separate PR when I have some time, I don't really use VSCode but I'll check out the markdown linter.

@sadlerm4
Copy link
Contributor Author

Apologies, fixed some spelling I just noticed.

@WeirdTreeThing WeirdTreeThing merged commit aaf4ccd into chrultrabook:main Apr 21, 2024
1 check passed
@sadlerm4 sadlerm4 deleted the seo branch April 22, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeirdTreeThing WeirdTreeThing WeirdTreeThing approved these changes

@ninelore ninelore ninelore approved these changes

@meghan06 meghan06 Awaiting requested review from meghan06

@ethanaobrien ethanaobrien Awaiting requested review from ethanaobrien

@mine-man3000 mine-man3000 Awaiting requested review from mine-man3000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEO: Headers
3 participants
@sadlerm4 @ninelore @WeirdTreeThing