Add way to add multiple load handlers to CefClient #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CefClient.addLoadHandler is a bit of a misnomer - it would be more accurate to name it setLoaderHandler, as it's only possible to set one load handler, subsequent calls to addLoaderHandler are ignored.
This is inconsistent with regular behaviour of addHandlers/addListeners (e.g. calling Logger.addHandler twice does add two Handlers, not one).
To not have to change any method signatures of CefClient, a convenience class LoadHandlerCollection is created, which itself is a LoadHandler, and calls all its child LoadHandlers when its own handler methods are called.