Update intro-to-storybook/ja #765
Conversation
There was a problem hiding this comment.
@UHAsikakutou appreciate the time you took to put together this pull request and add the much-deserved updates to the translation. 🙏 ! I've checked and left a couple of suggestions for you to look into when you have a moment. Also, if you're okay with it, as you are already working on updating the translation, can you check #768 and include those changes here? For context they're small adjustments to some of the examples.
Let me know once you've addressed it, and I'll be more than glad to take another pass at it so that we can get someone in the community to review it.
Will that work for you?
Have a fantastic day.
Stay safe
| loading: false, | ||
| export const Empty = { | ||
| args: { | ||
| // argsによってストーリーを形成します。 |
There was a problem hiding this comment.
@UHAsikakutou, I'd appreciate it if you could revert the comments in the tutorial back to English. We're aware that translating into a native language brings the translation closer to home (pardon the bad pun), but until we have a better way of handling it, we prefer to keep them as they are.
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
@UHAsikakutou can you replace the checkout action to be "actions/checkout@v4" instead?
| - run: yarn | ||
| #👇 Adds Chromatic as a step in the workflow | ||
| #👇 Chromaticをワークフローのステップとして追加 |
There was a problem hiding this comment.
Also, if you're ok with it, the chromaui action can be adjusted to be "chromaui/action@latest".
|
Thank you for reviewing my code, @jonniebigodes .
|
| export const Error = {}; | ||
| ``` const Error = Template.bind({}); | ||
| ``` |
There was a problem hiding this comment.
@UHAsikakutou, it seems that this is a bit of a typo. Can you fix this so that the example renders correctly?
There was a problem hiding this comment.
I'm sorry! I have fixed that.
|
Sorry, I missed one of your reviews. |
No description provided.