[ENH] Change assertions in integrity validation to exceptions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sicheng-Pan
force-pushed
the
12-30-_enh_change_assertions_in_integrity_validation_to_exceptions
branch
from
5cf0843 to
739ef39
Compare
|
Note: 3.7 is failing because of missing build images. The upstream is failing as well on the same test. I remove it here to pass the CI. |
HammadB
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We would like to enable validation for HNSW index on load
Changes
Assertions in the integrity validation code is updated to exceptions, so that upstream Rust code can handle the error. The only assertion left unchanged should always be true regardless the validation passes or fails.