Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Implement compaction client #3465

Merged
merged 3 commits into from
Jan 22, 2025
Merged

[ENH] Implement compaction client #3465

merged 3 commits into from
Jan 22, 2025

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Jan 10, 2025 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • N/A
  • New functionality
    • Implements the compaction client, which is a CLI tool that can be used to remotely control a compaction service.
    • For now it only allows for triggering an one-off compaction on selected collections (or all of available collections)

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan mentioned this pull request Jan 10, 2025
Merged
1 task
@Sicheng-Pan Graphite App
Copy link
Contributor Author

Sicheng-Pan commented Jan 10, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan mentioned this pull request Jan 10, 2025
Merged
1 task
@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review January 10, 2025 00:19
@Sicheng-Pan Sicheng-Pan force-pushed the 01-09-_enh_implement_compaction_client branch from ebef5bd to 0019d09 Compare January 10, 2025 18:46
@Sicheng-Pan Sicheng-Pan force-pushed the 12-31-_enh_handle_one-off_compaction_message_in_compaction_manager branch from 25ff5ed to fe94965 Compare January 14, 2025 22:30
@Sicheng-Pan Sicheng-Pan force-pushed the 01-09-_enh_implement_compaction_client branch from 0019d09 to b0e9a41 Compare January 14, 2025 22:30
@Sicheng-Pan Sicheng-Pan force-pushed the 12-31-_enh_handle_one-off_compaction_message_in_compaction_manager branch from fe94965 to 2e0c103 Compare January 15, 2025 00:25
@Sicheng-Pan Sicheng-Pan force-pushed the 01-09-_enh_implement_compaction_client branch from b0e9a41 to d61b29f Compare January 15, 2025 00:25
HammadB
HammadB reviewed Jan 21, 2025
View reviewed changes
rust/worker/src/bin/compaction_client.rs Outdated

#[cfg(not(target_env = "msvc"))]
#[global_allocator]
static GLOBAL: Jemalloc = Jemalloc;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i don't think this needs to use jemalloc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with default allocator

@Sicheng-Pan Sicheng-Pan force-pushed the 12-31-_enh_handle_one-off_compaction_message_in_compaction_manager branch from 2e0c103 to d2d6721 Compare January 21, 2025 21:47
@Sicheng-Pan Sicheng-Pan force-pushed the 01-09-_enh_implement_compaction_client branch from d61b29f to 6b58d86 Compare January 21, 2025 21:48
@Sicheng-Pan
Copy link
Contributor Author

Sicheng-Pan commented Jan 21, 2025 •
edited
Loading

Merge activity

  • Jan 21, 5:43 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 21, 6:32 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 21, 7:22 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 12-31-_enh_handle_one-off_compaction_message_in_compaction_manager to graphite-base/3465 January 21, 2025 22:44
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3465 to main January 21, 2025 23:29
@Sicheng-Pan Sicheng-Pan force-pushed the 01-09-_enh_implement_compaction_client branch from 6b58d86 to a827692 Compare January 21, 2025 23:31
@Sicheng-Pan Sicheng-Pan merged commit 02be5ca into main Jan 22, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sicheng-Pan @HammadB