Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue:#3026 Replaced ValueError and TypeError with InvalidArgumentError #3455

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rounakkraaj-1744
Copy link

#3026

Description of changes

  • Improvements & Bug fixes
    • Replaced all occurrences of ValueError and TypeError with InvalidArgumentError across the codebase for better error consistency and clarity.

Test plan

  • Verified that all test cases pass locally:

    • Run pytest for Python changes.
    • Run yarn test for JavaScript changes.
    • Run cargo test for Rust changes.
  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

  • Updated docstrings for all affected user-facing APIs to reflect the new InvalidArgumentError usage.
  • No changes required in the docs repository.

Copy link

github-actions bot commented Jan 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant