Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLD] Add link to hotfix PR in action summary #3433

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Jan 8, 2025

Description of changes

When applying a hotfix, a PR gets generated. This PR is currently only in the output of the action, or can be found in the list of PRs. This adds a heading and a link to the PR in the action summary so that the developer can find it more easily.

Test plan

I manually linted the action code to make sure I didn't break anything obvious. I may still want to tweak the output that gets generated, but at this point, the PR link will be much more easy to spot.

@eculver eculver requested a review from codetheweb January 8, 2025 00:54
Copy link

github-actions bot commented Jan 8, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@eculver eculver merged commit 818bb3d into main Jan 8, 2025
77 checks passed
@eculver eculver deleted the eculver/hotfix-workflow-summary branch January 8, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant