Drop 'encoding' keyword when loading json files, removed in Python 3.8 #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, running tests during the build with Python 3.9
fails like this:
It looks like the
encoding
keyword has been removed in newer Pythonversions.
The documentation for
json.load
says [1]:The doc for Python 3.7
json.loads
method (i.e. an extra 's' at theend of the method name) says:
and for 3.8, the 'encoding' param for that method is gone.
This reverts commit e63e49d,
"using utf-8 encoding when loading json files".
[1] https://docs.python.org/3/library/json.html