-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set stable versions of Carto components #35
base: master
Are you sure you want to change the base?
Set stable versions of Carto components #35
Conversation
* Modify order of the Docker file so it runs faster on version change iteration. * Set versions to early Jan 2018. Relates to: chriswhong#33
Why did you take this portion out of the README? It helped me in the past. |
@thadk check the now the volumes are created before hand in the readme so you end up having two named volumes that will be used by the container. This gives you couple of benfits:
|
Hey all, I am not able to maintain this anymore... Does someone want to be added as a collaborator who can review PRs and keep it going? |
If no one else has time I'm happy to volunteer. I'd also like to start a Roadmap so we can have longer term support. Starting with some automated builds and tests. |
@sabman I'll add you as a contributor. |
@chriswhong Thanks for doing the initial efforts for getting everything working in a docker container. We have been looking for something like this for an year or so, so I was really happy when I find your repo.
I had some issues though with the master branch.
1st the first problem was that it did not compile with Windshaft master. Issue #27 and
2nd after getting it running with an older version of Windshaft I started getting the
user/admin/api/v2/sql?q=select%20*%20from%20cdb_dataservices_client.cdb_service_quota_info()
issue, see #30 (comment)So I started looking into a way of pinning versions that worked taking the work done by @Prindle19 and @sabman in the ticket: #33
I manage to pin some version from Jan 2018 that work. My suggestion is if you want to merge this PR so everyone getting to your repo and running the build get a working version of Carto.
This PR covers:
Docker
file so it runs faster on version change iteration. Only the last steps got change when you change the version of the components.We should work into having more up to date version of the components and also try to move from ubuntu 12 to ubuntu 16, that's the recomended version in the Carto documentation.
This PR:
Closes #27
Closes #33
Closes #30
Closes #28
Closes #31
Relates #32
Relates #23 in some way.