Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to_yaml] Update wrapper scripts to allow them to run using var_defns.yaml #4

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

MichaelLueken
Copy link

DESCRIPTION OF CHANGES:

While running the Jenkins tests with the to_yaml branch in PR #1098, the Functional WorkflowTaskTests stage failed immediately. This stage runs wrapper scripts, not a workflow, which requires extra steps to work with the change from bash to YAML for var_defns. I have made the necessary cahnges to the wrapper scripts to allow them to run and move past this stage.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

TESTS CONDUCTED:

  • hera.intel - Ran the wrapper_srw_ftest.sh Jenkins script
  • hera.gnu - Ran the wrapper_srw_ftest.sh Jenkins script

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • My changes generate no new warnings
  • New and existing tests pass with my changes

Copy link
Owner

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to this community piece that I forgot about!

@christinaholtNOAA christinaholtNOAA merged commit 1afdf51 into christinaholtNOAA:to_yaml Jul 23, 2024
@MichaelLueken MichaelLueken deleted the to_yaml branch July 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants