select: getOptions async and isOptionEqualToValue #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
options
property, in Select control, now accepts PromisesisOptionEqualToValue
Why it was done
fetch
call. (callbacks can do it too, but I feel async are cooler)Example:
That alone would enable us more options to obtain.. er.. options.
But, would be more interesting to pass not the
id
as value, the object itself would be better since we wouldn't need to fetch it again later.So, the property
isOptionEqualToValue
will give us the answer to 'how an option object is equal to a potential string (or numeric) value?'Same example, objects as values instead of ids:
That way, at the node inputs resolve phase, we have the selected object to handle.