Renderer/Html/Array: Fix Undefined offset for callback fixSpaces #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoids breaking the callback when no spaces are to be counted. This is a fixup for 2900dd9 (chrisboulton#42)
lazyfrosch
force-pushed
the
fixspaces-array-offset
branch
from
0856f82
to
cb0d078
Compare
lazyfrosch
added a commit
to Icinga/icingaweb2-module-director
that referenced
this pull request
May 9, 2018
lazyfrosch
added a commit
to Icinga/icingaweb2-module-director
that referenced
this pull request
May 16, 2018
Thomas-Gelf
pushed a commit
to Icinga/icingaweb2-module-director
that referenced
this pull request
May 29, 2018
|
Is this project dead? |
If you don't mind a more modern (PHP >= 7.1 is required and PHP >= 7.4 is preferred) rewritten one: https://github.com/jfcherng/php-diff |
|
I second https://github.com/jfcherng/php-diff as a good and working alternative with a dev who actively maintains it and also implements new features! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It avoids breaking the callback when no spaces are to be counted.
This is a fixup for 2900dd9 (#42)
/cc @petrkotek